Skip to content

update compatibility_date for @cloudflare/next-on-pages documentation #20245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2025
Merged

update compatibility_date for @cloudflare/next-on-pages documentation #20245

merged 1 commit into from
Feb 25, 2025

Conversation

@excessivecoding
Copy link
Contributor

@excessivecoding excessivecoding commented Feb 25, 2025

Summary

As of the last version of Next.js, so pages failed on cloudflare pages

cf. issue cloudflare/next-on-pages#908

Documentation checklist

  • The documentation style guide has been adhered to.
  • If a larger change - such as adding a new page- an issue has been opened in relation to any incorrect or out of date information that this PR fixes.
  • Files which have changed name or location have been allocated redirects.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 25, 2025

Howdy and thanks for contributing to our repo. We review new, external PRs within 2 weeks. If it's been longer than then without any movement, tag the PR Assignees in a comment.

@ToriLindsay
Copy link
Contributor

ToriLindsay commented Feb 25, 2025

@dario-piotrowicz or @GregBrimble
Would you mind confirming this change? Thank you!

dario-piotrowicz
dario-piotrowicz approved these changes Feb 25, 2025
View reviewed changes
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @excessivecoding 🙂

@dario-piotrowicz dario-piotrowicz merged commit cc30d00 into cloudflare:production Feb 25, 2025
8 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes a docs contribution, big or small label Feb 25, 2025
@holopin-bot
Copy link

holopin-bot bot commented Feb 25, 2025

Congratulations @excessivecoding, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm7kvqfwk05540cl5pdtjzjws

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dario-piotrowicz dario-piotrowicz dario-piotrowicz approved these changes

@ToriLindsay ToriLindsay ToriLindsay approved these changes

@IgorMinar IgorMinar Awaiting requested review from IgorMinar

@jculvey jculvey Awaiting requested review from jculvey

@GregBrimble GregBrimble Awaiting requested review from GregBrimble GregBrimble is a code owner

Assignees

@jculvey jculvey

@IgorMinar IgorMinar

@GregBrimble GregBrimble

@dario-piotrowicz dario-piotrowicz

@ToriLindsay ToriLindsay

Labels

contribution [Holopin] Recognizes a docs contribution, big or small product:pages size/xs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@excessivecoding @ToriLindsay @dario-piotrowicz @jculvey @IgorMinar @GregBrimble @workers-devprod